FDN-3571: make install.sh faster & remove unused function #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first change removes the
run_maintenancestep ininstall.sh.That step is time consuming, memory consuming, more so as time goes
by. Eventually it will hit limits (e.g., number of locks acquired)
and fail. It happened in some repository already, and this step has
been removed there as a consequence. It is also an unnecessary step,
so we remove it.
Secondly, the
refresh_journalingis a function that just delegatesto the
_nativevariant, the only one possible these days. So inthis PR we swap them around and get rid of the wrapper.